feat(lint): add surface linters (YAML, shell, GitHub Actions)#20
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
ben-miru
force-pushed
the
feat/surface-linters
branch
from
a8b2a8e to
ee2b27b
Compare
Add non-Go surface linters matching those added to the core repository: - .yamllint.yml: yamllint config (ignores .agents/ subtree) - .github/actionlint.yml: actionlint config (minimal) - scripts/lint-surface.sh: runs yamllint, shellcheck, actionlint - scripts/install-lint-tools.sh: installs the three linters - surface-lint CI job in .github/workflows/ci.yml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The ludeeus/action-shellcheck step was scanning the .agents/ subtree, which contains scripts we don't own. Matches the exclusion already in scripts/lint-surface.sh. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The existing lint and test jobs use the ubuntu-latest-m self-hosted runner label. Without declaring it in .github/actionlint.yml, actionlint flags it as unknown — failing the new surface-lint CI job. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ben-miru
force-pushed
the
feat/surface-linters
branch
from
568a435 to
3cb9d35
Compare
Add lint-surface.sh (yamllint, shellcheck, actionlint) as a third parallel job in preflight.sh so local validation matches CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ben-miru
force-pushed
the
feat/surface-linters
branch
from
5262942 to
392d6b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/lint-surface.shandscripts/install-lint-tools.shto run and install yamllint, shellcheck, and actionlint — matching what was added to the core repository.yamllint.ymland.github/actionlint.ymlconfig files; yamllint ignores the.agents/subtreesurface-lintCI job to.github/workflows/ci.ymlusing SHA-pinned Actions for all three lintersubuntu-latest-mself-hosted runner label in actionlint config so the existinglintandtestjobs don't trigger unknown-label errorsChanges since rebase
Rebased onto latest
main(through #23) and added a fix commit to declare theubuntu-latest-mrunner label in.github/actionlint.yml— without this, actionlint would fail on the existing CI jobs that use that runner.