perf: run deadcode in parallel with golangci-lint#23
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When both golangci-lint and deadcode are enabled, launch them concurrently. Deadcode output is buffered and printed after both complete to avoid interleaving. Saves ~45s in CI since deadcode finishes within golangci-lint's runtime. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Split the parallel golangci-lint/deadcode logic into runAnalyzers and runAnalyzersParallel to keep runLintSteps under the 50-line function length limit. Also fix gofumpt formatting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The exhaustruct linter requires all struct fields to be explicitly initialized. The golangci-lint result was missing the outBuf field. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ben-miru
force-pushed
the
perf/parallel-deadcode
branch
from
c08aba7 to
1a690d7
Compare
ben-miru
added a commit
that referenced
this pull request
Apr 14, 2026
## Summary - Add `scripts/lint-surface.sh` and `scripts/install-lint-tools.sh` to run and install yamllint, shellcheck, and actionlint — matching what was added to the core repository - Add `.yamllint.yml` and `.github/actionlint.yml` config files; yamllint ignores the `.agents/` subtree - Add a `surface-lint` CI job to `.github/workflows/ci.yml` using SHA-pinned Actions for all three linters - Declare `ubuntu-latest-m` self-hosted runner label in actionlint config so the existing `lint` and `test` jobs don't trigger unknown-label errors ## Changes since rebase Rebased onto latest `main` (through #23) and added a fix commit to declare the `ubuntu-latest-m` runner label in `.github/actionlint.yml` — without this, actionlint would fail on the existing CI jobs that use that runner. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Benjamin Smidt <ben@miruml.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
TestRunLint_ParallelGolangciAndDeadcodeverifies both timings appear in outputmiru lintproduces correct output with parallel execution🤖 Generated with Claude Code