Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed bug where Webhooks would create like crazy. #404
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks, it was the mistake I made. |
monckey100
added some commits
Jan 16, 2019
Bjornskjald
changed the base branch from
master
to
dev
Jan 18, 2019
Bjornskjald
requested changes
Jan 18, 2019
|
Great pull request, thank you for your contributions |
lib/discord/login.js Outdated
| @@ -32,7 +42,12 @@ module.exports = message => { | |||
| log.trace('user', user) | |||
| if (user) { | |||
| log.debug(`Mentioning user ${match}`) | |||
| message = message.replace(`@${match}`, user) | |||
| if (user === 'deleted-role') { | |||
This comment has been minimized.
This comment has been minimized.
Bjornskjald
Jan 18, 2019
Member
Actually, the user can't be 'deleted-role' as it's an object, and not a string. Maybe check if the user is in the guild which the message is going to?
| module.exports = message => { | ||
| return { | ||
| body: message.content, | ||
| body: handleEmojis(message.content), |
This comment has been minimized.
This comment has been minimized.
Bjornskjald
Jan 18, 2019
Member
Could we just not strip emojis in the first place? There's no need to strip the emojis and then find them again.
This comment has been minimized.
This comment has been minimized.
monckey100
Jan 18, 2019
Author
Contributor
When receiving a message from Discord -> Discord, the Emoji does not parse at all, this is because it seems to be plaintext? However this current implementation still shows plaintext which makes me believe I might have to have the bot manually add in <:haha:1234567890>
lib/discord/handleEmojis.js Outdated
Bjornskjald
and others
added some commits
Jan 18, 2019
monckey100
closed this
Jan 21, 2019
This comment has been minimized.
This comment has been minimized.
|
Why did you close it? |
monckey100 commentedJan 18, 2019
How to reproduce: Specify a guild ID and then multilink servers.
Fix: By default it will now grab all guilds rather than a single if a guild ID is specified. The guild that is specified will then be pushing to position 0 as categorys is dependent on it being in the first position.