New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where Webhooks would create like crazy. #404

Closed
wants to merge 25 commits into
base: dev
from

Conversation

Projects
None yet
2 participants
@monckey100
Copy link
Contributor

monckey100 commented Jan 18, 2019

How to reproduce: Specify a guild ID and then multilink servers.

Fix: By default it will now grab all guilds rather than a single if a guild ID is specified. The guild that is specified will then be pushing to position 0 as categorys is dependent on it being in the first position.

@Bjornskjald

This comment has been minimized.

Copy link
Collaborator

Bjornskjald commented on lib/discord/handleMentions.js in ef5c711 Jan 16, 2019

Thanks, it was the mistake I made.

@Bjornskjald Bjornskjald changed the base branch from master to dev Jan 18, 2019

@Bjornskjald
Copy link
Member

Bjornskjald left a comment

Great pull request, thank you for your contributions 😄
Could you check my comments? Thanks

Show resolved Hide resolved lib/discord/login.js Outdated
@@ -32,7 +42,12 @@ module.exports = message => {
log.trace('user', user)
if (user) {
log.debug(`Mentioning user ${match}`)
message = message.replace(`@${match}`, user)
if (user === 'deleted-role') {

This comment has been minimized.

@Bjornskjald

Bjornskjald Jan 18, 2019

Member

Actually, the user can't be 'deleted-role' as it's an object, and not a string. Maybe check if the user is in the guild which the message is going to?

module.exports = message => {
return {
body: message.content,
body: handleEmojis(message.content),

This comment has been minimized.

@Bjornskjald

Bjornskjald Jan 18, 2019

Member

Could we just not strip emojis in the first place? There's no need to strip the emojis and then find them again.

This comment has been minimized.

@monckey100

monckey100 Jan 18, 2019

Author Contributor

When receiving a message from Discord -> Discord, the Emoji does not parse at all, this is because it seems to be plaintext? However this current implementation still shows plaintext which makes me believe I might have to have the bot manually add in <:haha:1234567890>

Show resolved Hide resolved lib/discord/handleEmojis.js Outdated

Bjornskjald and others added some commits Jan 18, 2019

Update lib/discord/login.js
Co-Authored-By: monckey100 <lf2owner@hotmail.com>

@monckey100 monckey100 closed this Jan 21, 2019

@Bjornskjald

This comment has been minimized.

Copy link
Member

Bjornskjald commented Jan 21, 2019

Why did you close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment