v0.4.0

[tarcieri]

• Add back (off-by-default) soft-aes feature (#10)
• Convert benchmark suite to use criterion.rs (#7)
• Refactor using ctr and stream-cipher crates (#6)
• Update dependencies (closes #2) (#4)
• Update to Rust 2018 edition (#3)

[dpc]

@tarcieri I've just tried to compile and got

   Compiling miscreant v0.4.0                                                                                                                         
error: unsupported target platform. Either enable appropriate target-features (+aes,+ssse3) in RUSTFLAGS or enable the 'soft-aes' cargo feature to fallback to a software AES implementation
  --> /home/dpc/.cargo/registry/src/github.com-1ecc6299db9ec823/miscreant-0.4.0/src/lib.rs:48:1                                                       
   |                                                                                                                                                  
48 | / compile_error!(                                                                                                                                
49 | |     "unsupported target platform. Either enable appropriate target-features (+aes,+ssse3) \                                                    
50 | |      in RUSTFLAGS or enable the 'soft-aes' cargo feature to fallback to a software AES implementation"                                         
51 | | );                                                                                                                                             
   | |__^                                                                                                                                             
            

It used to work in previous beta version. Is that expected?

[tarcieri]

Yes, I disabled software fallback by default (see #10).

Either enable the appropriate target-features to use the AES-NI version, or add the soft-aes cargo feature to get the previous behavior.

[dpc]

@tarcieri I'm looking at https://docs.rs/miscreant/0.4.0-beta2/miscreant/ and I am still a little bit unclear what do I want to do. :D

I think ideally the default should be "just work as fast as possible everywhere". soft-aes enable, and using hardware-support on platforms that support it.

So ... before (0.4.0-beta2) I was using soft-aes and no hardware support? And I won't get hardware support until I do rustflags = ["-Ctarget-feature=+aes"]? Is auto-detection of hardware capabilities implemented at all?

[tarcieri]

The only options right now are

• x86/x86_64 targets only: compile with AES-NI target features (+aes,+ssse3) and get an AES-NI hardware accelerated version
• all other targets: enable the soft-aes cargo feature to get a software fallback if the appropriate rustflags are not enabled

To my knowledge there's no support for runtime AES-NI detection /cc @newpavlov

[dpc]

BTW. 0.4.0 failed on docs.rs https://docs.rs/crate/miscreant/0.4.0

[tarcieri]

I saw 😜 See #14, #15

[tarcieri]

Regarding the ergonomics of target-feature, you might take a look at https://internals.rust-lang.org/t/policies-around-default-cpu-architecture/9142/6