New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uglify-es is stale #3156

Closed
asapach opened this Issue May 29, 2018 · 6 comments

Comments

Projects
None yet
6 participants
@asapach

asapach commented May 29, 2018

Bug report or feature request?
Release request

Uglify version (uglifyjs -V)
uglify-es 3.3.9

Notes
It has been more than 5 months since uglify-es was last released. The latest release on NPM is 3.3.9. Is it still supported? There are a bunch of fixes in master that we'd like to see released in the harmony branch.

@alexlamsl

This comment has been minimized.

Collaborator

alexlamsl commented May 29, 2018

uglify-es is no longer maintained.

@alexlamsl alexlamsl closed this May 29, 2018

@asapach

This comment has been minimized.

asapach commented May 29, 2018

Could you please mark the npm package as deprecated?

@kzc

This comment has been minimized.

Contributor

kzc commented May 30, 2018

@julmot

This comment has been minimized.

julmot commented Jun 21, 2018

Can you please point this out in the branch itself.

@aleclarson

This comment has been minimized.

aleclarson commented Aug 29, 2018

@alexlamsl Curious of the rationale behind that decision. This benchmark says uglify-es (at the time of writing) is almost 3x faster than uglify-js, so it seems strange to abandon it. Since you haven't deprecated it on NPM, should I assume you're only taking a break from maintaining it?

@edmorley

This comment has been minimized.

edmorley commented Sep 14, 2018

so it seems strange to abandon it. Since you haven't deprecated it on NPM, should I assume you're only taking a break from maintaining it?

uglify-es has been forked and the new project is called terser. For projects that need ES6 support, use it instead of uglify-es, since all new development will be happening over there (and things like webpack are switching over to it shortly too):
https://github.com/fabiosantoscode/terser

edmorley added a commit to edmorley/webpack that referenced this issue Sep 15, 2018

Switch from uglifyjs-webpack-plugin to terser-webpack-plugin
Some history:
* `uglifyjs-webpack-plugin` < v1.0 used the minifier `uglify-js`
* however `uglify-js` does not support ES6, which resulted in a fork
  called `uglify-es` that was developed in the `uglify-js` repository,
  but under the `harmony` branch
* `uglifyjs-webpack-plugin` v1.x switched to `uglify-es` for ES6 support
* however `uglify-es` stopped being maintained:
  mishoo/UglifyJS2#3156 (comment)
* which led to a fork called `terser` that has incorporated all of
  the unmerged PRs and will be where all new development occurs:
  https://github.com/fabiosantoscode/terser
* `terser-webpack-plugin` was created, which is the `terser` equivalent
  of `uglifyjs-webpack-plugin`:
  https://github.com/webpack-contrib/terser-webpack-plugin
* `uglifyjs-webpack-plugin` v2.x will be switching back to `uglify-js`,
  so any project that needs to support ES6 now needs to switch to
  `terser-webpack-plugin`.

Fixes #7923.

edmorley added a commit to edmorley/webpack that referenced this issue Sep 15, 2018

Switch from uglifyjs-webpack-plugin to terser-webpack-plugin
Some history:
* `uglifyjs-webpack-plugin` < v1.0 used the minifier `uglify-js`
* however `uglify-js` does not support ES6, which resulted in a fork
  called `uglify-es` that was developed in the `uglify-js` repository,
  but under the `harmony` branch
* `uglifyjs-webpack-plugin` v1.x switched to `uglify-es` for ES6 support
* however `uglify-es` stopped being maintained:
  mishoo/UglifyJS2#3156 (comment)
* which led to a fork called `terser` that has incorporated all of
  the unmerged PRs and will be where all new development occurs:
  https://github.com/fabiosantoscode/terser
* `terser-webpack-plugin` was created, which is the `terser` equivalent
  of `uglifyjs-webpack-plugin`:
  https://github.com/webpack-contrib/terser-webpack-plugin
* `uglifyjs-webpack-plugin` v2.x will be switching back to `uglify-js`,
  so any project that needs to support ES6 now needs to switch to
  `terser-webpack-plugin`.

Fixes #7923.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment