Permalink
Browse files

don't require git on the system for the gemspec

  • Loading branch information...
mislav committed Jul 27, 2010
1 parent 93e7b44 commit fccbb0b50666fe12be3fad93cf71ec0ad1e08642
Showing with 2 additions and 1 deletion.
  1. +2 −1 will_paginate.gemspec
View
@@ -17,5 +17,6 @@ Gem::Specification.new do |s|
s.rdoc_options = ['--main', 'README.rdoc', '--charset=UTF-8']
s.extra_rdoc_files = ['README.rdoc', 'LICENSE', 'CHANGELOG.rdoc']
- s.files = Dir['Rakefile', '{bin,lib,test,spec}/**/*', 'README*', 'LICENSE*'] & `git ls-files`.split("\n")
+ s.files = Dir['Rakefile', '{bin,lib,test,spec}/**/*', 'README*', 'LICENSE*']
+ s.files &= `git ls-files -z`.split("\0") if `type -t git 2>/dev/null || which git 2>/dev/null` && $?.success?

This comment has been minimized.

Show comment
Hide comment
@mhaley

mhaley Aug 4, 2010

Git isn't required anymore but the type or which commands are. The type command is different on Zsh and on Windows. The which command doesn't exist on Windows.

@mhaley

mhaley Aug 4, 2010

Git isn't required anymore but the type or which commands are. The type command is different on Zsh and on Windows. The which command doesn't exist on Windows.

This comment has been minimized.

Show comment
Hide comment
@mhaley

mhaley Aug 4, 2010

Or the type command

@mhaley

mhaley Aug 4, 2010

Or the type command

This comment has been minimized.

Show comment
Hide comment
@mislav

mislav Aug 4, 2010

Owner

I know they're not available. But do the errors appear? Or it silently fails? Because the latter is what I'm counting on.

@mislav

mislav Aug 4, 2010

Owner

I know they're not available. But do the errors appear? Or it silently fails? Because the latter is what I'm counting on.

This comment has been minimized.

Show comment
Hide comment
@mhaley

mhaley Aug 4, 2010

It shows an error on Windows, I've proposed a solution that fails silently in issue #60.

@mhaley

mhaley Aug 4, 2010

It shows an error on Windows, I've proposed a solution that fails silently in issue #60.

end

0 comments on commit fccbb0b

Please sign in to comment.