Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

:page parameter problem in the method paginate #13

Closed
bcaccinolo opened this Issue Oct 26, 2009 · 2 comments

Comments

Projects
None yet
3 participants

Hi,
The paginate method defaults to 1 the parameter :page if this one is false or nil. This parameter can also be an empty string. It could be good to defaults :page to 1 also in this case. We encountered this problem when our site is crawled by google bots.

Here is my patch to this bug
http://gist.github.com/218537

jerome commented Dec 12, 2009

+1

Owner

mislav commented Feb 5, 2010

I've heard about this issue, but don't consider it a problem. Newer Rails apps automatically respond to WillPaginate::InvalidPage issues being raised with a normal 404 response. If spiders feel the need of mangling get params and making up new URLs, they should get 404s, not get treated nicely.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment