Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

page_entries_info Doesn't Output Correctly (Rails 3.x.x+) #196

Closed
andrewtheis opened this Issue Nov 8, 2011 · 9 comments

Comments

Projects
None yet
6 participants

Take the following code for example:

<%= will_paginate @app_offers %>

<p class="center">
    <%= page_entries_info @app_offers %>
</p>

For some reason page_entries_info outputs the following:

Displaying all 2 App offer

Rather than what is expected:

Displaying all 2 app offers

It also ignores any input on changing the singular / plural names.

Owner

mislav commented Nov 9, 2011

You're right, I'm also seeing the bug. Thanks

Until this is fixed, you must translate your model name manually in your translation files. This is documented in Translating page of the wiki.

I'm having the same problem. I've made a pull request for this fix

#208

tobowers commented Jan 9, 2012

any word on this? We're having the same issue.

Owner

mislav commented Jan 10, 2012

Still haven't got to it but will try soon.

Of course, someone could also beat me to it. With tests.

@halloffame has a pull request ...

Owner

mislav commented Jan 11, 2012

@andrewtheis yes but it's worthless without tests. Also, it only works for English.

+1 on this issue.

same problem

Owner

mislav commented Jan 10, 2013

After some thought, I've decided that fixing this isn't worth it. All output from the page_entries_info method should be adjusted using i18n translations, as I've already suggested. Supporting proper pluralization parallel to i18n functionality would be just duplicated efforts, and locale files are superior anyway since the model translations there can benefit other parts of the application, too.

@mislav mislav closed this Jan 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment