require 'facets' extends Fixnum with a 'length' method causing wp_count to return an incorrect count #2

Closed
alakra opened this Issue Jul 6, 2009 · 5 comments

Projects

None yet

5 participants

alakra commented Jul 6, 2009

In finder.rb, in the wp_count method, there is a condition at the bottom of the method that checks
for whether the count responds to a length method. The popular facets gem breaks this. Perhaps, it might would be better to use is_a? instead of respond_to?

check finder.rb, line 238

ebryn commented Jul 21, 2009

having the same issue myself...

Contributor
jingoro commented Oct 22, 2009
alakra commented Nov 7, 2009

jingoro,

Thanks for patching up the problem. It works just fine.

fozze

@ghost
ghost commented Jun 4, 2010

This should be fixed now, not only this patch, but Facets has renamed the method.

Owner
mislav commented Sep 9, 2010

Pulled! thanks

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment