Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

require 'facets' extends Fixnum with a 'length' method causing wp_count to return an incorrect count #2

Closed
alakra opened this Issue · 5 comments

5 participants

Angelo Lakra Erik Bryn John Nishinaga Rubyworks Mislav Marohnić
Angelo Lakra

In finder.rb, in the wp_count method, there is a condition at the bottom of the method that checks
for whether the count responds to a length method. The popular facets gem breaks this. Perhaps, it might would be better to use is_a? instead of respond_to?

check finder.rb, line 238

Erik Bryn

having the same issue myself...

Angelo Lakra

jingoro,

Thanks for patching up the problem. It works just fine.

fozze

Rubyworks

This should be fixed now, not only this patch, but Facets has renamed the method.

Mislav Marohnić
Owner

Pulled! thanks

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.