Can't opt out of using simple search feature #315

Closed
rthbound opened this Issue Jun 20, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@rthbound

I've looked at the available options, but can't find what I think I need.

I would love if there was an option to tell will_paginate "don't try to use the simple search feature!"

The way the feature modifies the pagination links has my hands more tied than I'd like.

@mislav

This comment has been minimized.

Show comment Hide comment
@mislav

mislav Jun 20, 2013

Owner

What do you want to opt out of, specifically?

Owner

mislav commented Jun 20, 2013

What do you want to opt out of, specifically?

@rthbound

This comment has been minimized.

Show comment Hide comment
@rthbound

rthbound Jun 20, 2013

I'd like the option of not merging GET parameters into the page links.
Plane old /things?page=2...

I have worked around it, but still think the option would be nice.

-Tad Hosford
On Jun 20, 2013 5:31 PM, "Mislav Marohnić" notifications@github.com wrote:

What do you want to opt out of, specifically?


Reply to this email directly or view it on GitHubhttps://github.com/mislav/will_paginate/issues/315#issuecomment-19787814
.

I'd like the option of not merging GET parameters into the page links.
Plane old /things?page=2...

I have worked around it, but still think the option would be nice.

-Tad Hosford
On Jun 20, 2013 5:31 PM, "Mislav Marohnić" notifications@github.com wrote:

What do you want to opt out of, specifically?


Reply to this email directly or view it on GitHubhttps://github.com/mislav/will_paginate/issues/315#issuecomment-19787814
.

@mislav

This comment has been minimized.

Show comment Hide comment
@mislav

mislav Jun 20, 2013

Owner

You can create your own LinkRenderer:

class NoDefaultParamsRenderer < WillPaginate::ActionView::LinkRenderer
  def merge_get_params(url_params)
    url_params
  end
end

But since this behavior is essential, I won't provide an option to disable it simply because I think the majority would never use the option.

Owner

mislav commented Jun 20, 2013

You can create your own LinkRenderer:

class NoDefaultParamsRenderer < WillPaginate::ActionView::LinkRenderer
  def merge_get_params(url_params)
    url_params
  end
end

But since this behavior is essential, I won't provide an option to disable it simply because I think the majority would never use the option.

@mislav mislav closed this Jun 20, 2013

@rthbound

This comment has been minimized.

Show comment Hide comment
@rthbound

rthbound Jun 20, 2013

That's just fine. Thanks for getting back to me.

-Tad Hosford
On Jun 20, 2013 6:08 PM, "Mislav Marohnić" notifications@github.com wrote:

You can create your own LinkRenderer:

class NoDefaultParamsRenderer < WillPaginate::ActionView::LinkRenderer
def merge_get_params(url_params)
url_params
endend

But since this behavior is essential, I won't provide an option to disable
it simply because I think the majority would never use the option.


Reply to this email directly or view it on GitHubhttps://github.com/mislav/will_paginate/issues/315#issuecomment-19789475
.

That's just fine. Thanks for getting back to me.

-Tad Hosford
On Jun 20, 2013 6:08 PM, "Mislav Marohnić" notifications@github.com wrote:

You can create your own LinkRenderer:

class NoDefaultParamsRenderer < WillPaginate::ActionView::LinkRenderer
def merge_get_params(url_params)
url_params
endend

But since this behavior is essential, I won't provide an option to disable
it simply because I think the majority would never use the option.


Reply to this email directly or view it on GitHubhttps://github.com/mislav/will_paginate/issues/315#issuecomment-19789475
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment