Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Finder.wp_count use invalid select option and breaks counting request #9

Closed
ZenCocoon opened this Issue Aug 23, 2009 · 4 comments

Comments

Projects
None yet
3 participants

Hi,

Here we go with the second issue regarding the counting request :

SELECT count(users.*, addresses.full_address) AS count_users_all_addresses_full_address FROM ...

This case actually breaks.
Looks like the select option could have been replaced to produce the following request and work as expected :

SELECT COUNT(1) AS count_all FROM ...

Right now I work around this issue using the :count option of paginate but doesn't feel natural.
Let me know if you need further details.

P.S. : a BIG thanks for this wonderful gem.

dmitry commented Sep 7, 2009

Any news? :)

Owner

mislav commented Aug 2, 2011

Hey @ZenCocoon. I know this was a long time ago (sorry for that), but can you check again with latest will_paginate master and Rails 3?

I don't have enough info to check if this bug still exists.

Hi mislav,

Thanks for coming back to me on this. As you say, I've left just few info and don't see how to reproduce the error right now.
As far as I remember, this was under Rails 2.3.x without Arel. As so many changes as been done since, I would then consider this issue closed if you aim to target Rails 3 only.

Owner

mislav commented Aug 3, 2011

Well, Finder.wp_count only exist in will_paginate 3.0 pre-releases, which are not compatible with Rails 2.3. But I understand this was so long ago that you probably don't remember what was the issue.

Closing this ticket until we have proof that something is still broken (in either version)

@mislav mislav closed this Aug 3, 2011

@egiblin egiblin pushed a commit to egiblin/will_paginate that referenced this issue Feb 22, 2017

@AlexMerritt AlexMerritt Merge pull request #9 from codeforboston/mjz/add-rails-app
Add Rails App
051d538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment