Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Finder.wp_count use invalid select option and breaks counting request #9

Closed
ZenCocoon opened this Issue · 4 comments

3 participants

@ZenCocoon

Hi,

Here we go with the second issue regarding the counting request :

SELECT count(users.*, addresses.full_address) AS count_users_all_addresses_full_address FROM ...

This case actually breaks.
Looks like the select option could have been replaced to produce the following request and work as expected :

SELECT COUNT(1) AS count_all FROM ...

Right now I work around this issue using the :count option of paginate but doesn't feel natural.
Let me know if you need further details.

P.S. : a BIG thanks for this wonderful gem.

@dmitry

Any news? :)

@mislav
Owner

Hey @ZenCocoon. I know this was a long time ago (sorry for that), but can you check again with latest will_paginate master and Rails 3?

I don't have enough info to check if this bug still exists.

@ZenCocoon

Hi mislav,

Thanks for coming back to me on this. As you say, I've left just few info and don't see how to reproduce the error right now.
As far as I remember, this was under Rails 2.3.x without Arel. As so many changes as been done since, I would then consider this issue closed if you aim to target Rails 3 only.

@mislav
Owner

Well, Finder.wp_count only exist in will_paginate 3.0 pre-releases, which are not compatible with Rails 2.3. But I understand this was so long ago that you probably don't remember what was the issue.

Closing this ticket until we have proof that something is still broken (in either version)

@mislav mislav closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.