Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added german translation #155

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants

rockdog commented Aug 12, 2011

Hey,

I just added the de.yml with german translations.

Owner

mislav commented Aug 12, 2011

Thanks. I still haven't decided will I ship user-contributed translations with will_paginate, but I might if there are contributions for most major languages. Yours look fine, so I'll keep them around until there are more I can ship all together.

rockdog commented Aug 12, 2011

Sure. I´m fine with that because it´s not too hard to add those lines manually anyway. I just thought it would be nice to have them right after installing/updating.

I think I remember that it is a bad idea to include the translations with the gem, because Rails loads all translation files, whether they are used or not. Maybe it is a better approach to store the translations in gists and collect all of them on a Wiki-Page (Devise does it like this).

rockdog commented Aug 12, 2011

OK, that sounds reasonable. So the translation can also be found here https://gist.github.com/1141979

I've added an Arabic translation (another pull request) as well.

wpp commented May 11, 2015

Danke für die Übersetzung @rockdog!

Could you perhaps clarify how translations are dealt with at the moment?

Owner

mislav commented Oct 15, 2016

Thanks for the contribution, but I've decided not to store translations for other languages in this library. The reason behind my decision is that I would have a hard time maintaining those translations in the long run, especially if I needed to add new keys. This library will only ship with English translation as an example of how anyone can translate will_paginate themselves in their own apps.

@mislav mislav closed this Oct 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment