Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Respect pagination_options[:renderer] #176
This is related to the pull request I made earlier, it respects
There are few things wrong with your patch. First, you're not guarding yourself from editing options objects passed in from outside to the
But, since the last time I've talked I have thought a lot about this and related issues and I realized I can't encourage people to set a global link renderer. This is because of Rack apps mounted inside of each another, like Sinatra inside Rails. If a Rails user set a global link renderer that works with Rails url helpers, that link renderer would implicitly be used in Sinatra and break. The proper way of setting a default link renderer for your application would be wrapping the
So, I'm going to change the code to deprecate the global option and close this. Sorry about wasting your time, but even I didn't predict these problems.