Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use show exceptions public API instead of monkey patching an internal method. #206

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

Works on Rails 3.0, 3.1 and 3.2.

Owner

mislav commented Dec 20, 2011

If you just ran the test suite, that isn't enough. I don't have integration tests for when a Rails app boots up, so I test this manually.

Your change doesn't make this work in Rails 3.2 and removes the patch that makes it work in 3.0 and 3.1. The whole problem is that WillPaginate::InvalidPage isn't a exception class, but a tag module.

I've expanded my monkeypatching to include Rails 3.2 in 6f4390b

@mislav mislav closed this Dec 20, 2011

The problem is that status_code is no longer invoked for Rails 3.2:

https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/middleware/show_exceptions.rb#L68

It only exists so it doesn't break WillPaginate and it probably won't be there for Rails 3.2 final. I have no idea how to make it work with the tag module then. :(

Owner

mislav commented Dec 20, 2011

I know. I've seen the changes that you're made. If you look closely, I have modified it so in Rails 3.2 it monkeypatches the other status_code method.

LOL, my bad. Thanks @mislav!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment