Error during Rails 3.2 fail-safe response #215

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@calvincorreli

Did Rails 3.2 change since your change?

It looks like there's a bug again - status_code no longer takes any params.

Here's my fix - not sure if it's correct...

//Lars

@mislav

This comment has been minimized.

Show comment
Hide comment
@mislav

mislav Dec 26, 2011

Owner

Weird. I thought my code worked but now that you pointed it out, status_code indeed doesn't take an argument.

I'll incorporate this in somehow. Thanks

Owner

mislav commented Dec 26, 2011

Weird. I thought my code worked but now that you pointed it out, status_code indeed doesn't take an argument.

I'll incorporate this in somehow. Thanks

@henrik

This comment has been minimized.

Show comment
Hide comment
@henrik

henrik Jan 30, 2012

+1 for including this patch. Rails 3.2 with will_paginate shows 500 errors instead of debug info on dev errors, and instead of the 404 page in production.

henrik commented Jan 30, 2012

+1 for including this patch. Rails 3.2 with will_paginate shows 500 errors instead of debug info on dev errors, and instead of the 404 page in production.

@mislav mislav closed this in e5e6c47 Jan 31, 2012

@mislav

This comment has been minimized.

Show comment
Hide comment
@mislav

mislav Jan 31, 2012

Owner

@henrik all is well now in new 3.0.3 release. Sorry for the trouble.

Owner

mislav commented Jan 31, 2012

@henrik all is well now in new 3.0.3 release. Sorry for the trouble.

@henrik

This comment has been minimized.

Show comment
Hide comment
@henrik

henrik Feb 1, 2012

@mislav No worries. Thanks a lot!

henrik commented Feb 1, 2012

@mislav No worries. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment