add extra_attributes option that adds extra attributes to links. #228

Closed
wants to merge 1 commit into
from

Projects

None yet

5 participants

@bryanlarsen

This is a generalization of of issue #133 / issue #100, which adds the data-remote attribute. Not all ajax frameworks work the same was as rails ujs.

@bryanlarsen bryanlarsen add extra_attributes option that adds extra attributes to links.
This is a generalization of of issue #133.  Not all ajax frameworks
work the same was as rails ujs.
f36aaa4
@acesuares

+1

@acesuares

Was this ever merged?

@iox
iox commented Sep 17, 2012

@mislav, could you review this too? Thank you very much!

@dgilperez

+1!

@mislav
Owner
mislav commented Jan 10, 2013

:extra_attributes isn't descriptive enough. Extra attributes for what?

I realize that will_paginate output isn't easily customized, but throwing more options to the method doesn't make it any better; it just makes the plugin more complex, more difficult to use, and harder to maintain in the long run.

To customize output right now: as always, please subclass the LinkRenderer.

@mislav mislav closed this Jan 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment