Skip to content

add :ignore_params option to the action_view LinkRenderer #229

Closed
wants to merge 1 commit into from

3 participants

@bryanlarsen

the will_paginate view helper copies query parameters from the request
onto the page links. This is virtually always the right thing to do
for standard requests, but when the links are inside an HTML fragment
generated via AJAX, those links often contain extra params that
shouldn't be mirrored into the link.

@bryanlarsen bryanlarsen add :ignore_params option to the action_view LinkRenderer
the will_paginate view helper copies query parameters from the request
onto the page links.   This is virtually always the right thing to do
for standard requests, but when the links are inside an HTML fragment
generated via AJAX, those links often contain extra params that
shouldn't be mirrored into the link.
b74cd70
@iox
iox commented Sep 17, 2012

@mislav, could you review this too? Thank you very much!

@mislav
Owner
mislav commented Jan 10, 2013

I'm reluctant to add new options to will_paginate, as there is already too many of them.

This is related to #100 in a way that it's about tweaking links output. Yes, will_paginate doesn't let you do this easily right now. No, I don't think this is the solution. You may need to write your link renderer.

@mislav mislav closed this Jan 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.