Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

fix for "Error during failsafe response: private method `status_code' ca... #252

Closed
wants to merge 1 commit into from

3 participants

@bryanlarsen

fix for "Error during failsafe response: private method `status_code' called for #ActionDispatch::ExceptionWrapper:0x..."

The above error is dumped to the log whenever a backtrace is dumped to the log for an app that uses will_paginate along with a Rails 3.2 and Hobo 1.4.

Hobo 1.4 never uses ExceptionWrapper or status_code; I'm not sure why it brings out this behaviour in Rails. Regardless, status_code is public in Rails, so bringing it private is probably not a good idea.

@bryanlarsen bryanlarsen fix for "Error during failsafe response: private method `status_code'…
… called for #<ActionDispatch::ExceptionWrapper:0x...>"
369a52c
@iox

Hi @mislav, could you please review this pull request?

We are reaching Hobo 2.0 (http://hobocentral.net/blog/2012/09/12/hobo-2-0-0-pre1-released/) and it would be really helpful if we could clear this bug before the release, because it's quite annoying for the developers (they can't see Rails errors in the browser in development mode). Is there anything we can do to help you get this merged?

I'm gonna comment of a couple of other pull requests we'd also like to discuss/merge. Thank you very much!

@mislav
Owner

Pulled! Thanks

@mislav mislav closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 13, 2012
  1. @bryanlarsen

    fix for "Error during failsafe response: private method `status_code'…

    bryanlarsen authored
    … called for #<ActionDispatch::ExceptionWrapper:0x...>"
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 1 deletion.
  1. +0 −1  lib/will_paginate/railtie.rb
View
1  lib/will_paginate/railtie.rb
@@ -40,7 +40,6 @@ def self.add_locale_path(config)
module ShowExceptionsPatch
extend ActiveSupport::Concern
included { alias_method_chain :status_code, :paginate }
- private
def status_code_with_paginate(exception = @exception)
if exception.is_a?(WillPaginate::InvalidPage) or
(exception.respond_to?(:original_exception) &&
Something went wrong with that request. Please try again.