param duplication in sinatra view helper with optional params #287

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

@ickymettle

This fixes the bug with duplicate params being generated if the optional param keys are symbols.

#286

@mislav
Owner
mislav commented Jan 13, 2013

Looks OK. But how about having a test?

@mislav
Owner
mislav commented Jan 13, 2013

Oh, just seen you were a Ruby beginner and that there aren't any existing Sinatra tests in will_paginate, so writing a new test for this might be a too big of a challenge for you. Don't worry about that. I'll see what I can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment