Rails 3 support for Oracle database in paginate_by_sql #96

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@davesmylie

Small patch to support oracle database - this doesn't support the offset/limit keywords directly so must be faked with some extra sql.

Previously add_limits! handled this for you, but this has been removed in rails3.

Dave Smylie
Oracle doesn't support the OFFSET and LIMIT keywords. Previously this…
… was handled here by the rails add_limit! method

but this was removed in rails3. Faking it for oracle with some additional queries.
@quarklemotion

This comment has been minimized.

Show comment
Hide comment
@quarklemotion

quarklemotion Jul 4, 2011

I had the same problem with will_paginate and rails3 with Oracle 10g and made a local monkey patch that does the exact technique you are using, the nested query rownum-based paging. From my research, this is the most recommended paging technique in Oracle. I am using this same technique on a large Java application as well and have not run into any performance issues, etc. I hope this gets merged in soon.

I had the same problem with will_paginate and rails3 with Oracle 10g and made a local monkey patch that does the exact technique you are using, the nested query rownum-based paging. From my research, this is the most recommended paging technique in Oracle. I am using this same technique on a large Java application as well and have not run into any performance issues, etc. I hope this gets merged in soon.

@mislav

This comment has been minimized.

Show comment
Hide comment
@mislav

mislav Sep 27, 2011

Owner

Merge in c0e61aa

Owner

mislav commented Sep 27, 2011

Merge in c0e61aa

@mislav mislav closed this Sep 27, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment