Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Bug? : Column-filtered subselection of a syncable dataset : Unable to add rows to the dataset #207

Open
chanakyabhardwajj opened this Issue · 1 comment

2 participants

@chanakyabhardwajj

I have attached a simple code below, that reproduces the error :

//Create a syncable dataset
var ds = new Miso.Dataset({
  data: [{ one : 1, two : 2, three : 3 }], 
  sync:true
});


ds.fetch({ 
  success: function() {

    //Create a subselection using where
    var oneTwo = this.where({
      columns: ['three'],
      rows: function(row) {
        return row.one == 1;
      }
    });

    //This runs fine
    console.log(oneTwo.length);

    //This one fails to add the row
    ds.add({ one : 1, two : 4, three : 5 });

    console.log(oneTwo.length);
  }
});
@iros
Owner

As noted in pull req comment, can you separate out the fix for this issue from the reversing of the rows-to-remove? I will merge it then. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.