Momentjs upgrade #129

Merged
merged 4 commits into from May 29, 2012

Conversation

Projects
None yet
2 participants
Contributor

makoto commented May 24, 2012

Hi.

The old version (1.4) of moment.js seemed to have some bugs which is now fixed in 1.6.2

BTW, The test "Zero vals convert to null csv delimited"(test/unit/core.js line 157) was failing because data/withzeros.csv does not exist. I was not sure whether the test is still relevant or not, so left as is.

Owner

iros commented May 29, 2012

Can you please also change the moment.js version in package.json? I can't push to your branch.
Once that's done I will pull for 0.1.4 release.
Thanks for this work!

Contributor

makoto commented May 29, 2012

Hi.
Is this okay? https://github.com/makoto/dataset/commits/momentjs_upgrade Let me know if I need to send another pull request again. BTW, I am on vacation till 1st July, so may be slow responding.

iros merged commit 30e22bb into misoproject:master May 29, 2012

Owner

iros commented May 29, 2012

Much thanks @makoto.

Contributor

makoto commented Jun 18, 2012

Hi. https://github.com/misoproject/dataset/blob/master/dist/miso.ds.deps.0.1.3.js still has the old version (1.4, not 1.6.2). Do I need to do anything to put the new version into the latest distribution, or are you planning on the future release?

Owner

iros commented Jun 18, 2012

It is queued up for release 0.2. We roll our changes into releases. It will be out today or tomorrow.

Irene Ros
http://ireneros.com
(413) 265-3704 | imirene@gmail.com | protocol.by/ireneros

On Jun 18, 2012, at 4:13 AM, Makoto Inoue wrote:

Hi. https://github.com/misoproject/dataset/blob/master/dist/miso.ds.deps.0.1.3.js still has the old version (1.4, not 1.6.2). Do I need to do anything to put the new version into the latest distribution, or are you planning on the future release?


Reply to this email directly or view it on GitHub:
#129 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment