Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Making sure _initialize routine kicks off regardless of options. #181

merged 1 commit into from Oct 26, 2012


None yet
2 participants

iros commented Oct 26, 2012

Comes up in the perlin noise example. In constructor if options are blank it skips the _initialize routine, thus leaving this._idAttribute = undefined. When adding rows to this blank dataset, this._idAttribute is undefined and as a result a new property called "undefined" with a value on the row being added, breaking the actual add routine, because there is no column called "undefined".

Fixing this in the constructor.js results in a load order problem because in the builds derived.js is created before any of the parsers, and we need to set the default parser to the strict parser. This is because derived.js creates a new Dataset to steal its prototype.

I am triggering initialization now regardless of options state and I moved the derived.js in the build order to the bottom after importers and parsers.

This one is a bit nutty.

alexgraul added a commit that referenced this pull request Oct 26, 2012

Merge pull request #181 from misoproject/undefined-idAttribute
Making sure _initialize routine kicks off regardless of options.

@alexgraul alexgraul merged commit b9c32b4 into master Oct 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment