Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game variables added #233

Closed
wants to merge 65 commits into from

Conversation

@cfbenn
Copy link
Contributor

commented May 28, 2019

Section for game variables added with some basic details.

jabdoa2 and others added some commits Feb 2, 2019

Merge pull request #202 from avanwinkle/avanwinkle/mac-instructions-h…
…eadings

Downgrade headers to subheaders; clear whitespace
Update power_entry.rst
additional detail
Update game_mode.rst
I am suggesting some further information to clarify the second example, as I had to spend time trying to figure out what some of the items in the example meant.

"The example below creates a new mode called JAM_rollover, and uses a machine-wide player variable named pf_multiplier.  This variable is what can be used in other parts of the game logic to multiply values based on the current multiplier value, for example, when calculating end of ball bonuses.  The counter value lb_JAM_complete_count is used as the count value in the JAM_lanes_done{count==2} within the variable_player conditional event statements."
Update index.rst
Text is an introduction to stepper motors.  I don't know if there are any properties that can be monitored or related events.  I sent Jan pictures of a stepper and controller board.
Update servos.rst
Information on how to use max_servo_value to tune device
Update steppers.rst
more complex sample code.  Might be better placed in two code blocks config and base but I'm unsure how to format that
Merge pull request #212 from cfbenn/patch-11
Update multiple_screens.rst
slight clarification of example
I got fooled by the previous example thinking the shot name was a reserved key word
Merge pull request #214 from colemanomartin/patch-17
slight clarification of example
Update accruals.rst
clarify how to use conditional logic accrual.completed
Update optos.rst
Learn from my mistake
Update animation.rst
Removed text saying rotation not supported and extended with rotation examples
Update common_settings.rst
Extended to include rotation

jabdoa2 and others added some commits Apr 28, 2019

Merge pull request #221 from colemanomartin/patch-23
OK if I add myself to authors?
Merge pull request #222 from colemanomartin/patch-24
More info on DIP switch 6
Merge pull request #220 from colemanomartin/patch-22
Dipswitch 6 warning when using servos with PD-LED
Update mac.rst
pip upgrade instructions used "pip install --update pip" which is incorrect. Changed to "pip install --upgrade pip"
Update mpf-examples.rst
Added links to 0.5x.x example zips
Merge pull request #225 from ironspider/patch-1
Spelling error wireing to wiring
Spelling for > four
I'm going through the tutorial on first build and just doing some minor spelling fixes when I see them. I also just wanted to learn how making changes on Github works! Two birds with one stone.
add debug: yes
NOTE: I am not sure if the way I wrote that was correct since I am going through the tutorial for the first time but the sentence says "For example, if you have a modern style trough with a jam switch, you'd add the debug setting like this:" and then doesn't show debug: yes in the code block? So I think that needs to be added? So I just guessed that it should come after the "eject_coil_jam_pulse: 15ms" line?
numbers don't match
In the top section it sets s_start to "number: 10" but right after that it shows it as "number: 11". Since this is early on in the tutorial it probably makes more sense just to have them match? Either both 10 or both 11?
Merge pull request #230 from ironspider/patch-6
spelling add > adding
rotation documentation error
positive numbers are counterclockwise
enstalling > Installing
Don't know if you want a capital "I" or a lowercase "i"?
Merge pull request #232 from ironspider/patch-7
enstalling > Installing
Merge pull request #231 from colemanomartin/patch-25
rotation documentation error
Update shots.rst
Instructions said to add shots section to machine-wide config, but this is no longer supported. Changed best practice to putting shots in base mode config.
Corrected underline
Corrected underline
Game Variables section added.
Game Variables section added.
@jabdoa2

This comment has been minimized.

Copy link
Collaborator

commented May 30, 2019

merged this manually

@jabdoa2 jabdoa2 closed this May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.