Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws Error when attempting to define more than one default display #376

Merged
merged 5 commits into from Jun 30, 2019

Conversation

@GranolaDaniel
Copy link

commented Jun 25, 2019

@jabdoa2
Copy link
Collaborator

left a comment

Thanks for your effort! Looks good. Just some minor nitpicks.

Show resolved Hide resolved mpfmc/uix/display.py Outdated
Show resolved Hide resolved mpfmc/uix/display.py Outdated
Show resolved Hide resolved mpfmc/uix/display.py Outdated
Brian Williams
@jabdoa2

This comment has been minimized.

Copy link
Collaborator

commented Jun 25, 2019

One more:

Messages
========
mpfmc/uix/display.py
  Line: None
    pep8: E101 / indentation contains mixed spaces and tabs (col 1)
  Line: 153
    pep8: W191 / indentation contains tabs (col 1)

I can also fix that later if you want.

Brian Williams
@GranolaDaniel

This comment has been minimized.

Copy link
Author

commented Jun 25, 2019

One more:

Messages
========
mpfmc/uix/display.py
  Line: None
    pep8: E101 / indentation contains mixed spaces and tabs (col 1)
  Line: 153
    pep8: W191 / indentation contains tabs (col 1)

I can also fix that later if you want.

I believe that I've switched that line back to spaced indentation. Please let me know if you have any feedback, and thank you for the guidance!

@jabdoa2

This comment has been minimized.

Copy link
Collaborator

commented Jun 25, 2019

Now it complains about long lines again:

mpfmc/uix/display.py Line: 153 pep8: E501 / line too long (129 > 120 characters) (col 121)

Brian Williams

@jabdoa2 jabdoa2 merged commit 47a5550 into missionpinball:dev Jun 30, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jabdoa2

This comment has been minimized.

Copy link
Collaborator

commented Jun 30, 2019

Thanks for all the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.