Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control events to counters #1342

Merged
merged 3 commits into from Jun 15, 2019

Conversation

@dziedada
Copy link

commented Apr 23, 2019

Implements control events for the counter class, as well as unit tests. Implements the feature requested in issue 1180.
#1180

@jabdoa2

This comment has been minimized.

Copy link
Collaborator

commented Apr 23, 2019

Good change. The linter has some nitpicks:

Messages
========
mpf/devices/logic_blocks.py
  Line: 329
    pep257: D300 / Use """triple double quotes""" (found '''-quotes)
    pep257: D212 / Multi-line docstring summary should start at the first line
    pep257: D205 / 1 blank line required between summary line and description (found 0)
    pep257: D400 / First line should end with a period (not 'd')
    pep257: D401 / First line should be in imperative mood ('Return', not 'Returns')
  Line: 351
    pep257: D300 / Use """triple double quotes""" (found '''-quotes)
  Line: 364
    pep257: D300 / Use """triple double quotes""" (found '''-quotes)
  Line: 377
    pep257: D300 / Use """triple double quotes""" (found '''-quotes

mpf/config_spec.yaml Outdated Show resolved Hide resolved

@jabdoa2 jabdoa2 added this to the 0.53 milestone Apr 24, 2019

@avanwinkle
Copy link
Collaborator

left a comment

Looks good! A few notes on the boolean evaluations, and check on the new method of handling events with kwarg-accepting methods. Thanks for the work!

mpf/config_spec.yaml Outdated Show resolved Hide resolved
mpf/devices/logic_blocks.py Outdated Show resolved Hide resolved
mpf/devices/logic_blocks.py Outdated Show resolved Hide resolved
mpf/devices/logic_blocks.py Outdated Show resolved Hide resolved
@jabdoa2

This comment has been minimized.

Copy link
Collaborator

commented May 25, 2019

@dziedada Do you still want to work on this or should we take it over?

@jabdoa2 jabdoa2 force-pushed the dziedada:Control_events_in_counters branch from 2937abd to 5b6d37a Jun 15, 2019

@jabdoa2 jabdoa2 merged commit eb8d2db into missionpinball:dev Jun 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.