Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the virtual_pinball platform for VPX #1360

Merged
merged 6 commits into from May 7, 2019

Conversation

@mfuegemann
Copy link
Contributor

commented May 6, 2019

lamp and coil number format is now string
pulsesw added
Hardware rules for autofire_solenoids implemented
get_coilactive added for autofire_coils

mfuegemann added some commits May 1, 2019

- Lamp and Coil numbers can be of type string
- vpx_pulsesw added
- Hardware rules implemented
- vpx_get_coilactive added for autofire_coils
@jabdoa2

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

Messages
========
mpf/platforms/virtual_pinball/virtual_pinball.py
  Line: 281
    pep257: D400 / First line should end with a period (not ')')

mfuegemann added some commits May 7, 2019

@jabdoa2

This comment has been minimized.

Copy link
Collaborator

commented May 7, 2019

Looks very good. Tests still pass. Coding style is good. Let's merge!

@jabdoa2 jabdoa2 merged commit c9d4475 into missionpinball:dev May 7, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.