Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor disable_random setting on random_event_player #1374

Merged
merged 1 commit into from May 22, 2019

Conversation

@avanwinkle
Copy link
Collaborator

commented May 21, 2019

This PR adds support for a documented-but-unimplemented setting for RandomEventPlayer: disable_random.

The underlying Randomizer accepts a disable_random setting to return items sequentially, but RandomEventPlayer never passed the setting to the Randomizer. This PR makes that change, for both machine and player RandomEventPlayers.

Also changed: currently, the RandomEventPlayer sets the force_different and force_all properties on its Randomizer every time the randomizer is accessed. This PR increases the indentation of that behavior so that the properties are only set when the randomizer is created, not every time its used.

Also also, tests! Lots of tests!

@jabdoa2

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

Awesome. Looks very good!

@jabdoa2 jabdoa2 merged commit 6fd5b59 into missionpinball:dev May 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@avanwinkle avanwinkle deleted the avanwinkle:randomizer-disable-random branch May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.