Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't activate diverter if activate_event present #1386

Merged
merged 1 commit into from Jun 20, 2019

Conversation

@GabeKnuth
Copy link
Contributor

commented Jun 20, 2019

#1385

Seems pretty straightforward. Checked on my end and it works as desired. Could probably be merged upstream, too, but that's up to you.

If this needs a Unit Test, let me know. I've never written one, so I don't really know the process. I can figure it out, though.

@jabdoa2

This comment has been minimized.

Copy link
Collaborator

commented Jun 20, 2019

Looks good to me!

@GabeKnuth GabeKnuth merged commit 252e54b into dev Jun 20, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jabdoa2 jabdoa2 deleted the diverter_activate_fix branch Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.