From 22d1a0375dd9f3814db6623461785784858b9c86 Mon Sep 17 00:00:00 2001 From: Etienne Lemay Date: Sat, 30 Sep 2017 11:37:02 -0400 Subject: [PATCH] Revert Emoji back to a functional component --- src/components/category.js | 18 ++--- src/components/emoji.js | 137 +++++++++++++++++-------------------- src/components/preview.js | 4 +- 3 files changed, 75 insertions(+), 84 deletions(-) diff --git a/src/components/category.js b/src/components/category.js index 282f3863e..21de42d96 100644 --- a/src/components/category.js +++ b/src/components/category.js @@ -146,20 +146,20 @@ export default class Category extends React.Component { {emojis && emojis.map((emoji) => - + Emoji({ emoji: emoji, ...emojiProps }) )} {emojis && !emojis.length &&
- + {Emoji({ + ...emojiProps, + size: 38, + emoji: 'sleuth_or_spy', + onOver: null, + onLeave: null, + onClick: null, + })}
diff --git a/src/components/emoji.js b/src/components/emoji.js index 7e3edea9e..ae6dc2b9d 100644 --- a/src/components/emoji.js +++ b/src/components/emoji.js @@ -23,98 +23,87 @@ const _getSanitizedData = (props) => { return getSanitizedData(emoji, skin, set) } -export default class Emoji extends React.PureComponent { +const _handleClick = (e, props) => { + if (!props.onClick) { return } + var { onClick } = props, + emoji = _getSanitizedData(props) - constructor (props) { - super(props) - - this.handleClick = this.handleClick.bind(this) - this.handleEnter = this.handleEnter.bind(this) - this.handleLeave = this.handleLeave.bind(this) - } - - handleClick (e) { - if (!this.props.onClick) { return } + onClick(emoji, e) +} - const { onClick } = this.props, - emoji = _getSanitizedData(this.props) +const _handleOver = (e, props) => { + if (!props.onOver) { return } + var { onOver } = props, + emoji = _getSanitizedData(props) - onClick(emoji, e) - } + onOver(emoji, e) +} - handleEnter (e) { - if (!this.props.onOver) { return } +const _handleLeave = (e, props) => { + if (!props.onLeave) { return } + var { onLeave } = props, + emoji = _getSanitizedData(props) - const { onOver } = this.props, - emoji = _getSanitizedData(this.props) + onLeave(emoji, e) +} - onOver(emoji, e) +const Emoji = (props) => { + for (let k in Emoji.defaultProps) { + if (props[k] == undefined && Emoji.defaultProps[k] != undefined) { + props[k] = Emoji.defaultProps[k] + } } - handleLeave (e) { - if (!this.props.onLeave) { return } - - const { onLeave } = this.props, - emoji = _getSanitizedData(this.props) + var { unified, custom, imageUrl } = _getData(props), + style = {}, + children = props.children - onLeave(emoji, e) + if (!unified && !custom) { + return null } - render () { - var props = this.props; + if (props.native && unified) { + style = { fontSize: props.size } + children = unifiedToNative(unified) - var { unified, custom, imageUrl } = _getData(props), - style = {}, - children = props.children + if (props.forceSize) { + style.display = 'inline-block' + style.width = props.size + style.height = props.size + } + } else if (custom) { + style = { + width: props.size, + height: props.size, + display: 'inline-block', + backgroundImage: `url(${imageUrl})`, + backgroundSize: '100%', + } + } else { + let setHasEmoji = _getData(props)[`has_img_${props.set}`] - if (!unified && !custom) { + if (!setHasEmoji) { return null } - if (props.native && unified) { - style = { fontSize: props.size } - children = unifiedToNative(unified) - - if (props.forceSize) { - style.display = 'inline-block' - style.width = props.size - style.height = props.size - } - } else if (custom) { - style = { - width: props.size, - height: props.size, - display: 'inline-block', - backgroundImage: `url(${imageUrl})`, - backgroundSize: '100%', - } - } else { - let setHasEmoji = _getData(props)[`has_img_${props.set}`] - - if (!setHasEmoji) { - return null - } - - style = { - width: props.size, - height: props.size, - display: 'inline-block', - backgroundImage: `url(${props.backgroundImageFn(props.set, props.sheetSize)})`, - backgroundSize: `${100 * SHEET_COLUMNS}%`, - backgroundPosition: _getPosition(props), - } + style = { + width: props.size, + height: props.size, + display: 'inline-block', + backgroundImage: `url(${props.backgroundImageFn(props.set, props.sheetSize)})`, + backgroundSize: `${100 * SHEET_COLUMNS}%`, + backgroundPosition: _getPosition(props), } - - return - {children} - } + return _handleClick(e, props)} + onMouseEnter={(e) => _handleOver(e, props)} + onMouseLeave={(e) => _handleLeave(e, props)} + className='emoji-mart-emoji'> + {children} + } Emoji.propTypes = { @@ -145,3 +134,5 @@ Emoji.defaultProps = { onLeave: (() => {}), onClick: (() => {}), } + +export default Emoji diff --git a/src/components/preview.js b/src/components/preview.js index 7bf5662d7..3aabcd593 100644 --- a/src/components/preview.js +++ b/src/components/preview.js @@ -31,7 +31,7 @@ export default class Preview extends React.PureComponent { return
- + {Emoji({ key: emoji.id, emoji: emoji, ...emojiProps })}
@@ -51,7 +51,7 @@ export default class Preview extends React.PureComponent { } else { return
- {idleEmoji && idleEmoji.length && } + {idleEmoji && idleEmoji.length && Emoji({ emoji: idleEmoji, ...emojiProps })}