Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package size reduced from 87.35 KB to 79.43 KB #113

Merged
merged 5 commits into from Sep 27, 2017

Conversation

@bniwredyc
Copy link
Contributor

@bniwredyc bniwredyc commented Sep 17, 2017

No description provided.

@ai
Copy link
Contributor

@ai ai commented Sep 17, 2017

@bniwredyc can you show size-limit --why results? Did we remove all core-js?

@ai
Copy link
Contributor

@ai ai commented Sep 17, 2017

@EtienneLem are you OK with updating webpack? (I think latest webpack is always better)

@bniwredyc
Copy link
Contributor Author

@bniwredyc bniwredyc commented Sep 17, 2017

@ai you mean this picture?
image

and yes, no core-js left.
The thing is that babel uses core-js to polyfill some of es2015 features e.g. Symbols.
To do to it babel requires typeof helper:
image
which in its turn requires core-js module:
image

Also there were other cases where core-js was required, but I replaced babel helpers to less complex ones (e.g. without support of defineProperty for IE8).

@ai
Copy link
Contributor

@ai ai commented Sep 17, 2017

Great!

@EtienneLem this PR is last part of size optimization, which I promised you

@EtienneLem
Copy link
Member

@EtienneLem EtienneLem commented Sep 19, 2017

Thanks both of you. I want to do a thorough review before merging, but after that I’ll finally be ready to prepare a new release!

@EtienneLem
Copy link
Member

@EtienneLem EtienneLem commented Sep 26, 2017

Everything seems to be working, I’m however getting this size:
screen shot 2017-09-25 at 9 17 09 pm

Did I miss something? 🤔

@ai
Copy link
Contributor

@ai ai commented Sep 26, 2017

Can you show size-limit --why output?

@bniwredyc
Copy link
Contributor Author

@bniwredyc bniwredyc commented Sep 26, 2017

Confirmed, something went wrong. I think I modified something inside node_modules and forgot about it. Will fix it soon. Sorry.

@bniwredyc
Copy link
Contributor Author

@bniwredyc bniwredyc commented Sep 26, 2017

Found the problem: I indeed modified the babel's typeof helper (used for the Symbol support) inside node_modules.
So, to disable typeof transformation, I replaced es2015 preset with a set of its plugins without transform-es2015-typeof-symbol.
Double-checked a clean repository clone - everything seems to be working now.
c8d736d

@EtienneLem EtienneLem merged commit 5ef1c28 into missive:master Sep 27, 2017
@ai
Copy link
Contributor

@ai ai commented Sep 28, 2017

=^_^= waiting for release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants