Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: reflect @typescript-eslint/func-call-spacing deprecation #7

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

HotoRas
Copy link
Contributor

@HotoRas HotoRas commented Oct 9, 2024

What

  • Migrate @typescript-eslint/func-call-spacing to @stylistic/function-call-spacing

Why

  • To use latest eslint

Additional Info

#6

This works in my local computer with ESLint 9.12.0

Checklist

- Migrate `@typescript-eslint/func-call-spacing` to `@stylistic/function-call-spacing`
@zyoshoka
Copy link
Contributor

zyoshoka commented Oct 9, 2024

Thank you for working on this!

Cloud you migrate other deprecated rules listed on https://eslint.org/blog/2023/10/deprecating-formatting-rules/#the-deprecated-rules in the same way?

Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript側でdeprecatedになってるのはこれだけなので一旦これでマージしても良さそう(別途js側を対応させるという意味でissueのresolveではないけど)

configs/typescript.js Outdated Show resolved Hide resolved
configs/typescript.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
HotoRas and others added 2 commits November 14, 2024 17:33
Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>
Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>
@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Nov 15, 2024

※Context: とりあえずこれでTypeScript ESLintをv9系に上げられるようになる

@syuilo syuilo merged commit b8c2324 into misskey-dev:main Nov 15, 2024
@syuilo
Copy link
Member

syuilo commented Nov 15, 2024

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants