This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
feat: add type of gallery #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54
What
ギャラリーの構造体と、ギャラリー系APIの型定義を追加しました。
I added the gallery structure and the gallery-based API type definitions.
参照元 (Source)
Why
anyで、正確な型判定ができないため修正しました。any, which does not allow accurate type determination. So I fixed it.Additional info (optional)
コード全体に対してlinterを実行したところ差分が多くなりました。そのため、自分が対応した範囲のみで実行しています。
I ran the linter on the entire code and there were a lot of differences. Therefore, I am running it only on the area that I have addressed.
コミット数が多いので、問題なければ
Squash and mergeしてください。If there are too many commits, please
Squash and mergeif there is no problem.