Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.11.0でurlとuriのドメインが違うノートが読めない #15039

Open
1 task
tai-cha opened this issue Nov 23, 2024 · 8 comments · May be fixed by #15107
Open
1 task

2024.11.0でurlとuriのドメインが違うノートが読めない #15039

tai-cha opened this issue Nov 23, 2024 · 8 comments · May be fixed by #15107
Labels
🐛Bug Unexpected behavior 🌌Federation The Federation/ActivityPub feature 🔥high priority
Milestone

Comments

@tai-cha
Copy link
Contributor

tai-cha commented Nov 23, 2024

💡 Summary

Misskey 2024.11.0にしてから一部インスタンスの投稿がinboxで詰まるんだよな。 Error: note url & uri host mismatch: note url: とでている。

Error: note url & uri host mismatch: note url: https://www.threads.net/@taisy0_/post/DCsigu2yidt, note uri: https://threads.net/ap/users/17841405292037825/post/18472060960055737/

from: https://mi.taichan.site/notes/a0x9vlxbpj

(問題を認識したためIssueを建てたが自分ではまだ未再現)

該当コード部分はここかと思われる

if (this.utilityService.punyHost(url) !== this.utilityService.punyHost(note.id)) {

🥰 Expected Behavior

Threadsのようなパターンでもノートを受信し作成できる

🤬 Actual Behavior

ノートのバリデーションに引っかかり作成できていなさそう

📝 Steps to Reproduce

  1. Threadsのユーザーをフォロー
  2. Threadsのユーザーが投稿する
  3. 配送されるまで待ちinboxキューを確認

💻 Frontend Environment

* Model and OS of the device(s):
* Browser:
* Server URL:
* Misskey:

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service:
* Misskey: 2024.11.0
* Node:
* PostgreSQL:
* Redis:
* OS and Architecture:

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@tai-cha tai-cha added ⚠️bug? This might be a bug 🐛Bug Unexpected behavior 🌌Federation The Federation/ActivityPub feature and removed ⚠️bug? This might be a bug labels Nov 23, 2024
@samunohito samunohito added this to the v2024.11.1? milestone Nov 23, 2024
@samunohito

This comment has been minimized.

@samunohito

This comment has been minimized.

@samunohito

This comment has been minimized.

@fruitriin
Copy link
Contributor

なんか不思議なURLもエラーになってる ブリッジかな

2024-11-26T00:53:14.000Z gamelore misskey     stack: 'Error: note url & uri host mismatch: note url: https://fed.brid.gy/r/https://bsky.app/profile/did:plc:a76l6iv5hhnehnsrnvxfkskc/post/3lbst2cqc7c2g, note uri: https://bsky.brid.gy/convert/ap/at://did:plc:a76l6iv5hhnehnsrnvxfkskc/app.bsky.feed.post/3lbst2cqc7c2g\n' +

@samunohito
Copy link
Member

alternateでとってきたURLが以下に弾かれてvalidateContentTypeSetAsActivityPubまで流れてエラー…という所まで追いついた。お目汚し失礼…

if (href && this.utilityService.punyHost(url) === this.utilityService.punyHost(href)) {
return await this.signedGet(href, user, false);
}

@syuilo
Copy link
Member

syuilo commented Nov 26, 2024

note url & uri host mismatch だから意図した挙動の可能性がある

@syuilo
Copy link
Member

syuilo commented Nov 26, 2024

Threads側で修正してもらった方が良いかも

@samunohito
Copy link
Member

Sharkey側で検討されている…?
https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Unexpected behavior 🌌Federation The Federation/ActivityPub feature 🔥high priority
Projects
4 participants