Skip to content

Cannot send messages with Cmd+Enter in Messaging room (Chat) #8191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dogdriip opened this issue Jan 25, 2022 · 0 comments · Fixed by #8192
Closed

Cannot send messages with Cmd+Enter in Messaging room (Chat) #8191

Dogdriip opened this issue Jan 25, 2022 · 0 comments · Fixed by #8192
Labels
⚠️bug? This might be a bug

Comments

@Dogdriip
Copy link
Contributor

💡 Summary

In Messaging room (Chat), textarea cannot detect Cmd+Enter but Ctrl+Enter.

Actually, textarea in Chat waits for keypress event, but keypress event is no longer fired for non-printable keys (except Enter, Shift+Enter, Ctrl+Enter).

Also, keypress event and onkeypress event handler are deprecated. Instead onkeydown is recommended. See https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onkeypress

🙂 Expected Behavior

Cmd+Enter should send a message.

☹️ Actual Behavior

Cmd+Enter does not work, and Ctrl+Enter just works fine.

📝 Steps to Reproduce

  1. Go to Misskey chat and try to send message to someone with Cmd+Enter.

📌 Environment

  • Chrome 97.0.4692.71 (Official Build) (arm64)
  • macOS 11.4 (20F71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant