Skip to content

Conversation

@tamaina
Copy link
Contributor

@tamaina tamaina commented Jul 20, 2023

Resolve #11082

What

設定ファイルでRedisの全てのオプションを設定できるように

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #11329 (a2e05f7) into develop (47b6841) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #11329      +/-   ##
===========================================
- Coverage    77.81%   77.68%   -0.13%     
===========================================
  Files          917      917              
  Lines        92586    92562      -24     
  Branches      7777     7749      -28     
===========================================
- Hits         72042    71909     -133     
- Misses       20544    20653     +109     
Impacted Files Coverage Δ
packages/backend/src/GlobalModule.ts 96.07% <100.00%> (-0.67%) ⬇️
packages/backend/src/config.ts 96.46% <100.00%> (ø)
packages/backend/src/queue/const.ts 100.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

@tamaina tamaina marked this pull request as ready for review July 20, 2023 10:31
@github-actions github-actions bot requested a review from acid-chicken July 20, 2023 10:31
@tamaina tamaina requested a review from syuilo July 20, 2023 10:36
@tamaina
Copy link
Contributor Author

tamaina commented Jul 20, 2023

p1.a9z.devで動いてはいる

@tamaina tamaina merged commit 0a06eb2 into develop Jul 20, 2023
@tamaina tamaina deleted the redis-extra branch July 20, 2023 10:50
@syuilo
Copy link
Member

syuilo commented Jul 20, 2023

CHANGELOGの追加位置おかしくない?

@yukikwi
Copy link

yukikwi commented Jul 20, 2023

new Redis(config.redis) not work because key not match (example config.redis.pass in redis config option use password)
ref. https://www.npmjs.com/package/ioredis (topic: Connect to Redis)

tamaina added a commit that referenced this pull request Jul 20, 2023
slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
* enhance(backend): 設定ファイルでioredisの全てのオプションを指定可能に

* yappa kousuru

* fix

* fix?

* fix

* Revert "fix"

This reverts commit 227f19f.

* fix
slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redisにユーザー名とパスコード入力を強要する設定の場合にMisskeyが対応できない

4 participants