fix(model): skip sha256 check for non-LFS files in manifest pull#29
Merged
Merged
Conversation
The manifest generator writes an empty sha256 for non-LFS files (e.g. config.json, tokens.txt), but the downloader unconditionally compared the actual hash against the empty string, always failing. When sha256 is empty, fall back to file-size verification. When size is also unknown (0), skip integrity checks entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
koe manifest generatewrites an emptysha256for non-LFS files (e.g.config.json,tokens.txt). The downloader unconditionally compares the actual hash against this empty string, which always fails — making any manifest containing non-LFS files unpullable.Solution
sha256is empty, skip hash verification and fall back to file-size comparisonFiles changed
koe-core/src/model_manager.rsTest plan
make buildpasseskoe manifest generate+koe pullworks for repos with non-LFS files