fix(wizard): check config save return values and report failures#35
Merged
Conversation
Verify config_set returns Err on corrupted YAML and succeeds on valid config. These tests validate the Rust FFI contract that the ObjC layer should be checking.
configSet() was declared void and silently discarded the error code from sp_config_set. With 18-20 sequential writes, a mid-save failure (corrupted YAML, disk full, permission denied) would leave config partially saved with no user feedback. Now configSet returns BOOL, and the save method tracks all failures to show an alert when any write fails.
Move config_set tests after normalize_hotkey_config test to avoid merge conflict with statusbar-hotkey-display branch. Combine into one function to prevent parallel test races on HOME env var.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The ObjC
configSet()wrapper was declaredvoidand silently discardedthe error code from
sp_config_set(). With 18-20 sequential config writes,a mid-save failure (corrupted YAML, disk full) would leave config partially
saved with no user feedback.
What changed
configSet()now returnsBOOLand checks thesp_config_setreturn code.saveOkflag and shows an alertif any write fails.
config_seterror behavior (corrupted YAML,valid YAML).
Test plan
cargo test -p koe-core --lib— config tests passmakebuilds successfullychmod 444 ~/.koe/config.yaml, save in wizard — should showerror alert; restore permissions and verify normal save works