fix(config): align FeedbackSection serde defaults with config YAML#52
Merged
Conversation
FeedbackSection fields used `default_true` for serde defaults while DEFAULT_CONFIG_YAML set them to false. When the feedback section was missing from a user's config file, sounds would unexpectedly turn on. Change serde defaults to `#[serde(default)]` (bool defaults to false) to match the YAML template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_sound,stop_sound,error_sound) used#[serde(default = "default_true")], butDEFAULT_CONFIG_YAMLsets them all tofalse. When thefeedbacksection is missing from a user's config file, serde fills intrue, causing sounds to turn on unexpectedly.#[serde(default)](bool defaults tofalse) so they match the YAML template.Test plan
cargo test -p koe-core— 27 tests passfeedbacksection from~/.koe/config.yaml, relaunch app, verify no startup/stop sounds play