fix(config): use atomic write for config file updates#53
Merged
Conversation
Write config to a .yaml.tmp sibling file then rename into place. This prevents config corruption if the process crashes mid-write. Applied to config_set, migrate_config_v1_to_v2, and normalize_hotkey_config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config_set(),migrate_config_v1_to_v2(), andnormalize_hotkey_config()write config.yaml directly withstd::fs::write(). If the process crashes mid-write, the config file can be left truncated/corrupted.atomic_write_file()helper that writes to a.yaml.tmpsibling then renames into place, ensuring the config file is always either the old or new version.Test plan
cargo test -p koe-core— 27 tests passconfig.yamlis updated correctly.yaml.tmpfile lingers after normal operation