fix(mlx): guard callback installation with callbackLock#54
Merged
Conversation
startSession wrote callback/callbackCtx without holding the lock, while cancelInternal and invokeCallback both acquire it. This left a narrow window where an old async task could observe a half-updated callback pair. Wrap the installation in callbackLock to close the gap.
…talk Pass the session generation into invokeCallback and verify it under callbackLock before dispatching. This closes the window where an old eventTask passes the generation guard, then a new startSession swaps the callback, and the old task delivers stale events to the new session's callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MLXAsrManager.startSession()wrotecallbackandcallbackCtxwithout holdingcallbackLock, whilecancel()andinvokeCallback()both acquire it. This left a narrow window where an old async task could observe a half-updated callback pair.callbackLock.lock()/callbackLock.unlock()so all three sites (install, clear, invoke) share the same lock.Test plan