fix(app): hide MLX LLM provider on builds without mlx feature#68
Merged
Conversation
Mirror the ASR provider pattern: expose a feature-gated `supported_llm_providers()` from koe-core and let the Setup Wizard query it, so the x86_64 build (which omits the `mlx` cargo feature) no longer shows the MLX LLM option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On x86_64 builds, the
mlxcargo feature is disabled (seeMakefile/project.yml), but the Setup Wizard still hardcoded the "MLX (Apple Silicon)" entry in the LLM provider popup. This PR hides that option on builds that do not include themlxfeature, mirroring the pattern already used for the ASR provider popup.No behavior change for Apple Silicon builds — the MLX LLM option still appears as before.
Changes
koe-core/src/llm/mod.rs: addsupported_providers()that conditionally includes"mlx"behind#[cfg(feature = "mlx")].koe-core/src/lib.rs: exposesp_core_supported_llm_providers()FFI (mirrors the existingsp_core_supported_local_providers).KoeApp/Koe/Bridge/SPRustBridge.{h,m}: add-supportedLlmProviders.KoeApp/Koe/SetupWizard/SPSetupWizardWindowController.m: only add the MLX LLM menu item when the Rust core reports it as supported.Test plan