fix(app): hide Apple Speech provider on x86_64 builds#69
Merged
Conversation
SpeechTranscriber (introduced in macOS 26) never runs on x86_64: Intel Macs cannot upgrade past macOS 15, and a Rosetta process on Apple Silicon cannot load the on-device speech assets. The Setup Wizard previously still offered "Apple Speech (On-Device)" on x86_64 builds and then reported "Not supported for this language" for every locale. Drop the apple-speech cargo feature from the Koe-x86 build, and gate the wizard entry on both the runtime macOS check and the feature list returned by koe-core — mirroring the MLX/sherpa-onnx pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apple-speechcargo feature from the Koe-x86 build script.apple-speechto the feature-gatedsupported_providers()list inmodel_manager.rs, so the wizard can query it at runtime — mirroring the existing MLX / sherpa-onnx pattern.Changes
koe-core/src/model_manager.rs: include"apple-speech"insupported_providers()behind#[cfg(feature = "apple-speech")]KoeApp/project.yml: removeapple-speechfrom Koe-x86 cargo featuresKoeApp/Koe/SetupWizard/SPSetupWizardWindowController.m: gate the Apple Speech menu item on both@available(macOS 26.0, *)andsupportedLocalProvidersTest plan
make buildon Apple Silicon (macOS 26+) — Apple Speech option visible in Setup Wizardmake build-x86_64— Apple Speech option hidden in Setup Wizardcargo check --manifest-path koe-core/Cargo.toml(default features) passescargo check --manifest-path koe-core/Cargo.toml --no-default-features --features "sherpa-onnx"passes