Make the LLM max-token request field configurable#7
Merged
Conversation
Contributor
Author
|
noticed new requirements for contributing, updating PR |
b43cf5a to
2d2ccb2
Compare
Owner
You just need to modify the commit message, there are no other major problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes the max-token request field configurable for the OpenAI-compatible LLM integration.
Motivation
The known failure that prompted this change was observed with Azure AI Foundry, where requests fail when the max-token field does not match the target model's API expectations.
Azure's guidance for this issue indicates that some deployments require
max_completion_tokensinstead ofmax_tokens:https://learn.microsoft.com/en-us/answers/questions/2139738/openai-badrequesterror-error-code-400-((error-((me
Making this field configurable keeps Koe compatible with endpoints that require a different parameter name, while preserving the current default behavior.
Changes
max_token_parameterconfig option underllmmax_tokensandmax_completion_tokenswhen building chat completion requestsmax_tokensfor backward compatibility with existing setupsTesting