fix(logging): restore RUST_LOG env var support in init_logging#78
Merged
missuo merged 1 commit intoApr 13, 2026
Merged
Conversation
Replace hardcoded filter_level(Info) with Builder::from_env() so the RUST_LOG environment variable can control log verbosity at runtime. Default filter remains 'info' when RUST_LOG is not set. Co-authored-by: Davy <thedavidweng@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
RUST_LOGenvironment variable support ininit_logging()by replacing hardcodedfilter_level(Info)withBuilder::from_env(). Default filter remainsinfowhenRUST_LOGis not set.Motivation
The current implementation ignores
RUST_LOGentirely, contradictingDESIGN.md§25.3:This makes it impossible to enable debug-level logging without modifying source code.
Changes
koe-core/src/telemetry.rs:init_logging()now usesenv_logger::Builder::from_env(Env::default().default_filter_or("info"))instead ofbuilder().filter_level(Info)Behavior
RUST_LOGsetRUST_LOG=debugRUST_LOG=koe_core=debugTesting
cargo check --no-default-features -p koe-core— ✅cargo clippy --no-default-features -p koe-core— ✅ (1 pre-existing warning, unrelated)cargo test --no-default-features -p koe-core— ✅ 44 tests passcargo fmt --check— ✅