Skip to content

feat(setup): add LLM timeout + remote model picker#84

Merged
missuo merged 3 commits into
missuo:mainfrom
imocat:codex/llm-timeout-model-picker-base-8f
Apr 13, 2026
Merged

feat(setup): add LLM timeout + remote model picker#84
missuo merged 3 commits into
missuo:mainfrom
imocat:codex/llm-timeout-model-picker-base-8f

Conversation

@imocat

@imocat imocat commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add editable global llm.timeout_ms field in Setup Wizard LLM pane
  • add OpenAI-compatible remote model picker via GET {base_url}/models while keeping manual model input
  • add collapsible model picker row and make lower form rows move up/down without blank gap
  • add profile name editing field mapped to llm.profiles..name

Details

  • new core FFI endpoint: sp_llm_list_models_json(base_url, api_key)
  • bridge wrapper: llmRemoteModelsForBaseURL:apiKey:
  • Setup Wizard now supports:
    • profile rename (name field)
    • timeout numeric input restriction
    • choose/hide model list row with refresh

Verification

  • cargo test -p koe-core llm::openai_compatible::tests -- --nocapture

@missuo

missuo commented Apr 13, 2026

Copy link
Copy Markdown
Owner

@imocat Pls resolve conflicts

@imocat

imocat commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

have done

@missuo missuo merged commit 467baad into missuo:main Apr 13, 2026
missuo added a commit that referenced this pull request Apr 13, 2026
Replace the single profile popup with a Finder-style sidebar table
(SPLlmProfileRowView) plus +/- buttons, and split the right side
into a detail form (Name + read-only Type + provider-specific
fields). Provider type is now locked at profile creation time
rather than switchable via a popup, which removes a class of bugs
where switching provider mid-edit silently dropped fields and made
the saved state hard to reason about.

Other tweaks rolled in:
- ASR test result label moved below the Test button so multi-line
  errors no longer truncate.
- Add a custom NSTableRowView subclass that paints a soft accent
  selection so the active profile stays visible when the detail
  form steals first-responder focus.
- Carry forward PR #84's Timeout (ms) field, Choose/Hide model
  picker button, remote /models popup with Refresh, retagged
  OpenAI field range to 2001-2008. The new picker logic reads
  provider from the active profile dictionary instead of the
  removed llmProviderPopup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants