From ae2205aeb54f43b63e58aadfbb5dd749e1c98d98 Mon Sep 17 00:00:00 2001 From: Dmitry Goryunov Date: Wed, 15 Nov 2017 17:39:43 +0100 Subject: [PATCH] Filter out unavailable databases (#3875) --- superset/views/core.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/superset/views/core.py b/superset/views/core.py index e5ae70846e76..bebf17fd237c 100755 --- a/superset/views/core.py +++ b/superset/views/core.py @@ -130,6 +130,14 @@ def apply(self, query, func): # noqa return query.filter(self.model.perm.in_(perms)) +class DatabaseFilter(SupersetFilter): + def apply(self, query, func): + if self.has_all_datasource_access(): + return query + perms = self.get_view_menus('database_access') + return query.filter(self.model.perm.in_(perms)) + + class DashboardFilter(SupersetFilter): """List dashboards for which users have access to at least one slice""" @@ -203,6 +211,7 @@ class DatabaseView(SupersetModelView, DeleteMixin): # noqa ] add_template = 'superset/models/database/add.html' edit_template = 'superset/models/database/edit.html' + base_filters = [['perm', DatabaseFilter, lambda:[]]] base_order = ('changed_on', 'desc') description_columns = { 'sqlalchemy_uri': utils.markdown(