Skip to content

Conversation

@ninezero90hy
Copy link
Contributor

@ninezero90hy ninezero90hy commented Oct 20, 2020

In the example, there is a renamed file in the library you are using
I think it's because you didn't lock the package
I'm sure you had a reason why you didn't lock the package, so I quickly fixed the problem

@mistic100 What do you think? 😉

Merge request checklist

  • I read the guidelines for contributing
  • I created my branch from dev and I am issuing the PR to dev
  • I didn't pushed the dist directory
  • Unit tests are OK
  • If it's a new feature, I added the necessary unit tests
  • If it's a new language, I filled the __locale and __author fields

@ninezero90hy
Copy link
Contributor Author

ninezero90hy commented Oct 20, 2020

I didn't modify the function!
I don't think my change caused me to fail the unit test. :)
The test is also failing in the master branch 🤔
No? @mistic100 Is it my problem?

@mistic100
Copy link
Owner

mistic100 commented Oct 20, 2020

@ninezero90hy tests are failing for months and I never found why (it works on a local computer).

Could you update the version to "^1.0.0" in both the package.json and bower.json (though someday this file will be removed) ?

@ninezero90hy
Copy link
Contributor Author

ninezero90hy commented Oct 20, 2020

I didn't understand exactly, but do you mean to change the library version I changed to ^1.0.0?

@ninezero90hy
Copy link
Contributor Author

  "dependencies": {
    ...
    "jquery-extendext": "0.1.2",
    ...
  }

I think locking the package is a fundamental solution.
I think that if you don't lock the package, another problem may arise later by another library.
If you don't want to fix the example, I think it's a good idea to fix the jquery-extendext version to 0.1.2.

@mistic100 What do you think?
This is what I think.

I think a lot of people would like to see the samples.

@ninezero90hy
Copy link
Contributor Author

Oh! And I'm just wondering, is there a reason why you don't lock the package?
It's just a question 😉

@mistic100
Copy link
Owner

mistic100 commented Oct 20, 2020

I think locking the package prevents to get fixes, moreover because QueryBuilder is not released often, and extendext is mine.
The error was to define ">=" but "^" is totally fine.

No it should not be locked to 0.1.2 because this is an outdated version.


Version locking is done my the end-users not the librairies, unless there is a strong know incompatibility.

@ninezero90hy
Copy link
Contributor Author

ninezero90hy commented Oct 20, 2020

Okay! So you're saying the modified sample is correct?

@mistic100 mistic100 merged commit 7027a02 into mistic100:dev Nov 2, 2020
@ninezero90hy ninezero90hy deleted the bugfix/fixed-example branch November 11, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants