-
Notifications
You must be signed in to change notification settings - Fork 562
Modify the library load information being used in the example #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I didn't modify the function! |
|
@ninezero90hy tests are failing for months and I never found why (it works on a local computer). Could you update the version to "^1.0.0" in both the package.json and bower.json (though someday this file will be removed) ? |
|
|
"dependencies": {
...
"jquery-extendext": "0.1.2",
...
}I think locking the package is a fundamental solution. @mistic100 What do you think? I think a lot of people would like to see the samples. |
|
Oh! And I'm just wondering, is there a reason why you don't lock the package? |
|
I think locking the package prevents to get fixes, moreover because QueryBuilder is not released often, and extendext is mine. No it should not be locked to 0.1.2 because this is an outdated version. Version locking is done my the end-users not the librairies, unless there is a strong know incompatibility. |
|
Okay! So you're saying the modified sample is correct? |
In the example, there is a renamed file in the library you are using
I think it's because you didn't lock the package
I'm sure you had a reason why you didn't lock the package, so I quickly fixed the problem
@mistic100 What do you think? 😉
Merge request checklist
devand I am issuing the PR todevdistdirectory__localeand__authorfields