Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Some fixes for PowerPC #18

Closed
wants to merge 4 commits into from

2 participants

@rbrito

Dear @mistydemeo,

I have some changes here for some programs.

I got a bit distracted and did not work on the previous pull request and I saw that some of the changes that I had here conflicted with recent changes on your tree.

Therefore, please consider this pull request and ignore the other momentarily. I will see what is still relevant from that pull request and send you a cleaned up version of that.

Thanks.

rbrito added some commits
@rbrito rbrito gmp: Fix compilation of gmp on Altivec-enabled Macs.
Signed-off-by: Rogério Brito <rbrito@ime.usp.br>
0e7a0e1
@rbrito rbrito harfbuzz: Fix compilation on powerpc.
Signed-off-by: Rogério Brito <rbrito@ime.usp.br>
2dbbfad
@rbrito rbrito mplayer: Depend on yasm only for intel.
Signed-off-by: Rogério Brito <rbrito@ime.usp.br>
d37d7a6
@rbrito rbrito qt: Partial fix for compilation of Qt on powerpc.
Signed-off-by: Rogério Brito <rbrito@ime.usp.br>
bbf0f5e
@mistydemeo
Owner

gmp builds and passes make check for me on my PowerBook G4 (built using gcc-4.2). What hardware/configuration did it fail for you on? Can you post build logs?

@mistydemeo

Do you know if qt supports ppc64 as a target?

@rbrito

@mistydemeo, the problem that I was having with gmp was with gcc 4.2 saying something along the lines of "such and such are only available with altivec when -force_cpusubtype_ALL is defined". I will try to get the exact message again.

Just for the record, here I am using an iBook G4 with Leopard. Yours is on Tiger?

@mistydemeo
Owner

Hm, I can't get harfbuzz to build on Tiger with or without m4.

@rbrito
@mistydemeo mistydemeo referenced this pull request from a commit
@mistydemeo mplayer: only use yasm on Intel
Refs #18.
7ebf716
@mistydemeo
Owner

I may try to confirm this, but I was almost giving up with tigerbrew and installing Linux back on this notebook... Anyway, thanks for the reply. It was like a heartbeat of the project for me, telling me that the issues raised are still relevant.

I'm really sorry about not responding to these sooner. Life has been really strange and I'm in the process of coordinating a cross-country move. :( Trying to get the tigerbrew backlog taken care of, and will try to keep on top from now on.

@mistydemeo
Owner

I've incorporated 3 of the 4 fixes; harfbuzz I'll look at when I have a Leopard machine to work with. A tigerbrewer has generously offered to send me a Leopard box, so I'll have something to test with in the future.

@rbrito

I totally lost track of this while working on other stuff. I will close this if you don't mind and will reopen as needed, OK?

@rbrito rbrito closed this
@mistydemeo
Owner

Sure thing.

I'll have that Leopard machine in ~another month, at which point I can take a more serious look at harfbuzz. Sorry about the delay on it! (Still can't get it working on Tiger, which I think is a separate issue...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 4, 2013
  1. @rbrito

    gmp: Fix compilation of gmp on Altivec-enabled Macs.

    rbrito authored
    Signed-off-by: Rogério Brito <rbrito@ime.usp.br>
  2. @rbrito

    harfbuzz: Fix compilation on powerpc.

    rbrito authored
    Signed-off-by: Rogério Brito <rbrito@ime.usp.br>
  3. @rbrito

    mplayer: Depend on yasm only for intel.

    rbrito authored
    Signed-off-by: Rogério Brito <rbrito@ime.usp.br>
  4. @rbrito

    qt: Partial fix for compilation of Qt on powerpc.

    rbrito authored
    Signed-off-by: Rogério Brito <rbrito@ime.usp.br>
This page is out of date. Refresh to see the latest.
View
1  Library/Formula/gmp.rb
@@ -21,6 +21,7 @@ def install
ENV.append 'ABI', '32'
end
+ ENV.append_to_cflags "-force_cpusubtype_ALL" if Hardware.cpu_type == :ppc
system "./configure", "--prefix=#{prefix}", "--enable-cxx"
system "make"
system "make check"
View
1  Library/Formula/harfbuzz.rb
@@ -8,6 +8,7 @@ class Harfbuzz < Formula
depends_on 'pkg-config' => :build
depends_on 'glib'
depends_on 'icu4c' => :recommended
+ depends_on 'm4' => :build if MacOS.version <= :leopard
# Needs newer fontconfig than XQuartz provides for pango
depends_on 'fontconfig'
View
2  Library/Formula/mplayer.rb
@@ -10,7 +10,7 @@ class Mplayer < Formula
option 'with-x', 'Build with X11 support'
option 'without-osd', 'Build without OSD'
- depends_on 'yasm' => :build
+ depends_on 'yasm' => :build if Hardware.cpu_type == :intel
depends_on 'xz' => :build
depends_on :x11 if build.include? 'with-x'
View
16 Library/Formula/qt.rb
@@ -83,12 +83,16 @@ def install
args << "-nomake" << "demos" << "-nomake" << "examples"
end
- if MacOS.prefer_64_bit? or build.universal?
- args << '-arch' << 'x86_64'
- end
-
- if !MacOS.prefer_64_bit? or build.universal?
- args << '-arch' << 'x86'
+ if Hardware.cpu_type != :ppc
+ if MacOS.prefer_64_bit? or build.universal?
+ args << '-arch' << 'x86_64'
+ end
+
+ if !MacOS.prefer_64_bit? or build.universal?
+ args << '-arch' << 'x86'
+ end
+ else
+ args << '-arch' << 'ppc'
end
if build.with? 'debug-and-release'
Something went wrong with that request. Please try again.