Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenDyslexic font as alternative user setting #1826

Merged
merged 2 commits into from Sep 10, 2019

Conversation

@bartmathijssen
Copy link
Member

commented Sep 9, 2019

Resolves #1606

@AppInventorWorkerBee

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

Can one of the admins verify this patch?

@ewpatton
Copy link
Member

left a comment

@bartmathijssen Two small changes to address. Also, why are the OpenDyslexicAlta* files needed? and the italics? You don't reference them in the CSS.

appinventor/appengine/war/Ya.css Outdated Show resolved Hide resolved
appinventor/blocklyeditor/media/ai2blockly.css Outdated Show resolved Hide resolved
@bartmathijssen

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

@ewpatton I removed the unused OpenDyslexic files, they must have been there from when I started working from #1639. I also resolved the other issues that were present.

@ewpatton
Copy link
Member

left a comment

LGTM

@ewpatton ewpatton merged commit bcd2cc3 into mit-cml:master Sep 10, 2019

@ewpatton ewpatton referenced this pull request Sep 11, 2019

@bartmathijssen bartmathijssen deleted the bartmathijssen:opendyslexic branch Sep 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.